London Class 9 - Farzaneh Haghani - Node - Class work#19
Open
farzaneh-haghani wants to merge 3 commits intoCodeYourFuture:masterfrom
Open
London Class 9 - Farzaneh Haghani - Node - Class work#19farzaneh-haghani wants to merge 3 commits intoCodeYourFuture:masterfrom
farzaneh-haghani wants to merge 3 commits intoCodeYourFuture:masterfrom
Conversation
JDysiewicz
reviewed
Apr 9, 2023
Member
JDysiewicz
left a comment
JDysiewicz
left a comment
There was a problem hiding this comment.
Some minor error handling changes, but overall really nice work!!
Comment on lines
+24
to
+25
| const amount = req.query.amount; | ||
| res.status(200).json(`You asked for ${amount} chocolate!`); |
Member
There was a problem hiding this comment.
How would you handle the case where amount wasn't passed in as a query param?
Comment on lines
+46
to
+50
| albums.forEach((album, index) => { | ||
| if (album.albumId === req.params.id) { | ||
| albums.splice(index, 1); | ||
| res.status(200).json("Deleted"); | ||
| } |
Member
There was a problem hiding this comment.
Could add an else case here which returns a 404 status
| }) | ||
| }); | ||
|
|
||
| app.listen(3000, () => { |
Member
There was a problem hiding this comment.
Usually we'd define the port as an environment variable and give it a default value, e.g. const PORT = process.env.PORT ?? 3000, app.listen(PORT, ...) - this makes it easier to deploy when you come around to doing that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.